Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Use ALIGN_* macros in _dl_map_object_from_fd.
Cleanup _dl_map_object_from_fd to make it clear exactly
what we're doing with the mappings i.e. extending the the
start of the map down to a page boundary, extending the
end of the map up to a page boundary, and offset itself
also to page boundary. The result is much easier to read
as expected from the ALIGN_* cleanups.
  • Loading branch information
Carlos O'Donell committed Sep 18, 2015
1 parent e952e1d commit 60084e3
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
5 changes: 5 additions & 0 deletions ChangeLog
@@ -1,3 +1,8 @@
2015-09-18 Carlos O'Donell <carlos@redhat.com>

* elf/dl-load.c: Include libc-internal.h.
(_dl_map_object_from_fd): Use ALIGN_UP and ALIGN_DOWN.

2015-09-18 Vincent Bernat <vincent@bernat.im>

[BZ #17887]
Expand Down
8 changes: 4 additions & 4 deletions elf/dl-load.c
Expand Up @@ -36,6 +36,7 @@
#include <caller.h>
#include <sysdep.h>
#include <stap-probe.h>
#include <libc-internal.h>

#include <dl-dst.h>
#include <dl-load.h>
Expand Down Expand Up @@ -1077,12 +1078,11 @@ _dl_map_object_from_fd (const char *name, int fd, struct filebuf *fbp,
}

struct loadcmd *c = &loadcmds[nloadcmds++];
c->mapstart = ph->p_vaddr & ~(GLRO(dl_pagesize) - 1);
c->mapend = ((ph->p_vaddr + ph->p_filesz + GLRO(dl_pagesize) - 1)
& ~(GLRO(dl_pagesize) - 1));
c->mapstart = ALIGN_DOWN (ph->p_vaddr, GLRO(dl_pagesize));
c->mapend = ALIGN_UP (ph->p_vaddr + ph->p_filesz, GLRO(dl_pagesize));
c->dataend = ph->p_vaddr + ph->p_filesz;
c->allocend = ph->p_vaddr + ph->p_memsz;
c->mapoff = ph->p_offset & ~(GLRO(dl_pagesize) - 1);
c->mapoff = ALIGN_DOWN (ph->p_offset, GLRO(dl_pagesize));

/* Determine whether there is a gap between the last segment
and this one. */
Expand Down

0 comments on commit 60084e3

Please sign in to comment.