Skip to content

Commit

Permalink
Help the compiler recognize unreachable code on 32-bit machines.
Browse files Browse the repository at this point in the history
2007-10-16  Ulrich Drepper  <drepper@redhat.com>

	* time/tzfile.c (__tzfile_read): Help the compiler recognize
	unreachable code on 32-bit machines.
  • Loading branch information
Ulrich Drepper committed Oct 16, 2007
1 parent 800d6f9 commit 6a649d2
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 7 deletions.
5 changes: 5 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
2007-10-16 Ulrich Drepper <drepper@redhat.com>

* time/tzfile.c (__tzfile_read): Help the compiler recognize
unreachable code on 32-bit machines.

2007-10-16 Jakub Jelinek <jakub@redhat.com>

[BZ #5184]
Expand Down
8 changes: 4 additions & 4 deletions sysdeps/i386/elf/configure
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
if test "$usetls" != no; then
# Check for support of thread-local storage handling in assembler and
# linker.
echo "$as_me:$LINENO: checking for i386 TLS support" >&5
echo $ECHO_N "checking for i386 TLS support... $ECHO_C" >&6
{ echo "$as_me:$LINENO: checking for i386 TLS support" >&5
echo $ECHO_N "checking for i386 TLS support... $ECHO_C" >&6; }
if test "${libc_cv_386_tls+set}" = set; then
echo $ECHO_N "(cached) $ECHO_C" >&6
else
Expand Down Expand Up @@ -37,8 +37,8 @@ else
fi
rm -f conftest*
fi
echo "$as_me:$LINENO: result: $libc_cv_386_tls" >&5
echo "${ECHO_T}$libc_cv_386_tls" >&6
{ echo "$as_me:$LINENO: result: $libc_cv_386_tls" >&5
echo "${ECHO_T}$libc_cv_386_tls" >&6; }
if test $libc_cv_386_tls = yes; then
cat >>confdefs.h <<\_ACEOF
#define HAVE_TLS_SUPPORT 1
Expand Down
6 changes: 3 additions & 3 deletions time/tzfile.c
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ __tzfile_read (const char *file, size_t extra, char **extrap)
& ~(__alignof__ (struct leap) - 1));
leaps_idx = total_size;
total_size += num_leaps * sizeof (struct leap);
tzspec_len = (trans_width == 8
tzspec_len = (sizeof (time_t) == 8 && trans_width == 8
? st.st_size - (ftello (f)
+ num_transitions * (8 + 1)
+ num_types * 6
Expand All @@ -263,14 +263,14 @@ __tzfile_read (const char *file, size_t extra, char **extrap)
types = (struct ttinfo *) ((char *) transitions + types_idx);
zone_names = (char *) types + num_types * sizeof (struct ttinfo);
leaps = (struct leap *) ((char *) transitions + leaps_idx);
if (trans_width == 8)
if (sizeof (time_t) == 8 && trans_width == 8)
tzspec = (char *) leaps + num_leaps * sizeof (struct leap) + extra;
else
tzspec = NULL;
if (extra > 0)
*extrap = (char *) &leaps[num_leaps];

if (sizeof (time_t) == 4 || trans_width == 8)
if (sizeof (time_t) == 4 || __builtin_expect (trans_width == 8, 1))
{
if (__builtin_expect (fread_unlocked (transitions, trans_width + 1,
num_transitions, f)
Expand Down

0 comments on commit 6a649d2

Please sign in to comment.