* nis/nis_callback.c (__nis_create_callback): Always call xdr_free

for cleanup when cb!=NULL [Coverity CID 233].
git-mirror · May 25, 2006 · 6bcb494 · 6bcb494
1 parent 07bfff2
commit 6bcb494
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -1,3 +1,8 @@
+2006-05-25  Ulrich Drepper  <drepper@redhat.com>
+
+	* nis/nis_callback.c (__nis_create_callback): Always call xdr_free
+	for cleanup when cb!=NULL [Coverity CID 233].
+
 2006-05-24  Ulrich Drepper  <drepper@redhat.com>
 
 	[BZ #2693]

diff --git a/nis/nis_callback.c b/nis/nis_callback.c
@@ -360,8 +360,7 @@ __nis_create_callback (int (*callback) (const_nis_name, const nis_object *,
     {
       if (cb->xprt)
 	svc_destroy (cb->xprt);
-      if (cb->serv)
-	xdr_free ((xdrproc_t) _xdr_nis_server, (char *) cb->serv);
+      xdr_free ((xdrproc_t) _xdr_nis_server, (char *) cb->serv);
       free (cb);
     }
   if (!nomsg)