Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
* nss/nsswitch.c (__nss_lookup_function): Don't cast &ni->known to
	void **.
	* nss/nsswitch.h (service_user): Use void * type for KNOWN field.

	* nss/nss_files/files-hosts.c (LINE_PARSER): Cast host_addr to
	char * to avoid warning.
	* nis/nss_nis/nis-hosts.c (LINE_PARSER): Likewise.

	* timezone/Makefile (CFLAGS-zdump.c): Add -fwrapv.

	* locale/programs/ld-ctype.c (ctype_finish, set_class_defaults,
	allocate_arrays): Cast second argument to charmap_find_symbol
	to char * to avoid warnings.

	* locale/programs/repertoire.c (repertoire_new_char): Change
	from_nr, to_nr and cnt to unsigned long, adjust printf format
	string.

	* locale/programs/ld-collate.c (insert_value, handle_ellipsis):
	Cast second argument to new_element to char * to avoid warnings.

	* locale/weightwc.h (findidx): Cast &extra[-i] to const int32_t *.

	* intl/gettextP.h (struct loaded_domain): Change plural to const
	struct expression *.
	* intl/plural-eval.c (plural_eval): Change first argument to
	const struct expression *.
	* intl/plural-exp.c (EXTRACT_PLURAL_EXPRESSION): Change first
	argument to const struct expression **.
	* intl/plural-exp.h (EXTRACT_PLURAL_EXPRESSION, plural_eval): Adjust
	prototypes.
	* intl/loadmsgcat (_nl_unload_domain): Cast away const
	in call to __gettext_free_exp.

	* posix/fnmatch.c (fnmatch): Rearrange code to avoid maybe
	unitialized wstring/wpattern var warnings.

	* posix/runtests.c (struct a_test): Make data field const char *.

	* stdio-common/tst-sprintf2.c (main): Don't declere u, v and buf
	vars if not LDBL_MANT_DIG >= 106.

	* stdio-common/Makefile (CFLAGS-vfwprintf.c): Add -Wno-unitialized.

	* stdio-common/vfprintf.c (vfprintf): Cast first arugment to
	__find_specmb to avoid warning.

	* rt/tst-mqueue1.c (do_one_test): Add casts to avoid warnings.

	* debug/test-strcpy_chk.c (do_tests, do_random_tests): Add casts
	to avoid warnings.

	* sysdeps/ieee754/ldbl-96/s_roundl.c (huge): Add L suffix to
	initializer.

	* sysdeps/unix/clock_gettime.c (clock_gettime): Only define
	tv var when it will be actually used.

	* sunrpc/rpc_cmsg.c (xdr_callmsg): Cast IXDR_PUT_* to void
	to avoid warnings.
  • Loading branch information
Ulrich Drepper committed Jul 28, 2007
1 parent 085a441 commit 701666b
Show file tree
Hide file tree
Showing 26 changed files with 155 additions and 71 deletions.
61 changes: 61 additions & 0 deletions ChangeLog
@@ -1,5 +1,66 @@
2007-07-26 Jakub Jelinek <jakub@redhat.com>

* nss/nsswitch.c (__nss_lookup_function): Don't cast &ni->known to
void **.
* nss/nsswitch.h (service_user): Use void * type for KNOWN field.

* nss/nss_files/files-hosts.c (LINE_PARSER): Cast host_addr to
char * to avoid warning.
* nis/nss_nis/nis-hosts.c (LINE_PARSER): Likewise.

* timezone/Makefile (CFLAGS-zdump.c): Add -fwrapv.

* locale/programs/ld-ctype.c (ctype_finish, set_class_defaults,
allocate_arrays): Cast second argument to charmap_find_symbol
to char * to avoid warnings.

* locale/programs/repertoire.c (repertoire_new_char): Change
from_nr, to_nr and cnt to unsigned long, adjust printf format
string.

* locale/programs/ld-collate.c (insert_value, handle_ellipsis):
Cast second argument to new_element to char * to avoid warnings.

* locale/weightwc.h (findidx): Cast &extra[-i] to const int32_t *.

* intl/gettextP.h (struct loaded_domain): Change plural to const
struct expression *.
* intl/plural-eval.c (plural_eval): Change first argument to
const struct expression *.
* intl/plural-exp.c (EXTRACT_PLURAL_EXPRESSION): Change first
argument to const struct expression **.
* intl/plural-exp.h (EXTRACT_PLURAL_EXPRESSION, plural_eval): Adjust
prototypes.
* intl/loadmsgcat (_nl_unload_domain): Cast away const
in call to __gettext_free_exp.

* posix/fnmatch.c (fnmatch): Rearrange code to avoid maybe
unitialized wstring/wpattern var warnings.

* posix/runtests.c (struct a_test): Make data field const char *.

* stdio-common/tst-sprintf2.c (main): Don't declere u, v and buf
vars if not LDBL_MANT_DIG >= 106.

* stdio-common/Makefile (CFLAGS-vfwprintf.c): Add -Wno-unitialized.

* stdio-common/vfprintf.c (vfprintf): Cast first arugment to
__find_specmb to avoid warning.

* rt/tst-mqueue1.c (do_one_test): Add casts to avoid warnings.

* debug/test-strcpy_chk.c (do_tests, do_random_tests): Add casts
to avoid warnings.

* sysdeps/ieee754/ldbl-96/s_roundl.c (huge): Add L suffix to
initializer.

* sysdeps/unix/clock_gettime.c (clock_gettime): Only define
tv var when it will be actually used.

* sunrpc/rpc_cmsg.c (xdr_callmsg): Cast IXDR_PUT_* to void
to avoid warnings.

* iconvdata/gbk.c (BODY): Make buf and cp char instead of unsigned
char array resp. pointer.
* iconvdata/iso-2022-kr.c (BODY): Make buf unsigned char instead of
Expand Down
11 changes: 7 additions & 4 deletions debug/test-strcpy_chk.c
Expand Up @@ -141,8 +141,8 @@ do_test (size_t align1, size_t align2, size_t len, size_t dlen, int max_char)
if (align2 + len >= page_size)
return;

s1 = buf1 + align1;
s2 = buf2 + align2;
s1 = (char *) buf1 + align1;
s2 = (char *) buf2 + align2;

for (i = 0; i < len; i++)
s1[i] = 32 + 23 * i % (max_char - 32);
Expand Down Expand Up @@ -233,7 +233,9 @@ do_random_tests (void)
chk_fail_ok = 1;
if (setjmp (chk_fail_buf) == 0)
{
res = CALL (impl, p2 + align2, p1 + align1, dlen);
res = (unsigned char *)
CALL (impl, (char *) p2 + align2,
(char *) p1 + align1, dlen);
printf ("Iteration %zd - did not __chk_fail\n", n);
chk_fail_ok = 0;
ret = 1;
Expand All @@ -242,7 +244,8 @@ do_random_tests (void)
continue;
}
memset (p2 - 64, '\1', 512 + 64);
res = CALL (impl, p2 + align2, p1 + align1, dlen);
res = (unsigned char *)
CALL (impl, (char *) p2 + align2, (char *) p1 + align1, dlen);
if (res != STRCPY_RESULT (p2 + align2, len))
{
printf ("\
Expand Down
5 changes: 3 additions & 2 deletions intl/gettextP.h
@@ -1,5 +1,6 @@
/* Header describing internals of libintl library.
Copyright (C) 1995-1999, 2000, 2001, 2004-2005 Free Software Foundation, Inc.
Copyright (C) 1995-1999, 2000, 2001, 2004-2005, 2007
Free Software Foundation, Inc.
This file is part of the GNU C Library.
Written by Ulrich Drepper <drepper@cygnus.com>, 1995.
Expand Down Expand Up @@ -147,7 +148,7 @@ struct loaded_domain
struct converted_domain *conversions;
size_t nconversions;

struct expression *plural;
const struct expression *plural;
unsigned long int nplurals;
};

Expand Down
2 changes: 1 addition & 1 deletion intl/loadmsgcat.c
Expand Up @@ -1276,7 +1276,7 @@ _nl_unload_domain (domain)
size_t i;

if (domain->plural != &__gettext_germanic_plural)
__gettext_free_exp (domain->plural);
__gettext_free_exp ((struct expression *) domain->plural);

for (i = 0; i < domain->nconversions; i++)
{
Expand Down
6 changes: 3 additions & 3 deletions intl/plural-eval.c
@@ -1,5 +1,5 @@
/* Plural expression evaluation.
Copyright (C) 2000, 2001 Free Software Foundation, Inc.
Copyright (C) 2000, 2001, 2007 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
Expand All @@ -17,14 +17,14 @@
Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
02111-1307 USA. */

static unsigned long int plural_eval (struct expression *pexp,
static unsigned long int plural_eval (const struct expression *pexp,
unsigned long int n)
internal_function;

static unsigned long int
internal_function
plural_eval (pexp, n)
struct expression *pexp;
const struct expression *pexp;
unsigned long int n;
{
switch (pexp->nargs)
Expand Down
4 changes: 2 additions & 2 deletions intl/plural-exp.c
@@ -1,5 +1,5 @@
/* Expression parsing for plural form selection.
Copyright (C) 2000, 2001, 2005 Free Software Foundation, Inc.
Copyright (C) 2000, 2001, 2005, 2007 Free Software Foundation, Inc.
Written by Ulrich Drepper <drepper@cygnus.com>, 2000.
This file is part of the GNU C Library.
Expand Down Expand Up @@ -99,7 +99,7 @@ void
internal_function
EXTRACT_PLURAL_EXPRESSION (nullentry, pluralp, npluralsp)
const char *nullentry;
struct expression **pluralp;
const struct expression **pluralp;
unsigned long int *npluralsp;
{
if (nullentry != NULL)
Expand Down
11 changes: 5 additions & 6 deletions intl/plural-exp.h
@@ -1,5 +1,5 @@
/* Expression parsing and evaluation for plural form selection.
Copyright (C) 2000, 2001, 2002, 2005 Free Software Foundation, Inc.
Copyright (C) 2000, 2001, 2002, 2005, 2007 Free Software Foundation, Inc.
Written by Ulrich Drepper <drepper@cygnus.com>, 2000.
This file is part of the GNU C Library.
Expand Down Expand Up @@ -114,13 +114,12 @@ extern void FREE_EXPRESSION PARAMS ((struct expression *exp))
internal_function;
extern int PLURAL_PARSE PARAMS ((void *arg));
extern const struct expression GERMANIC_PLURAL attribute_hidden;
extern void EXTRACT_PLURAL_EXPRESSION PARAMS ((const char *nullentry,
struct expression **pluralp,
unsigned long int *npluralsp))
internal_function;
extern void EXTRACT_PLURAL_EXPRESSION PARAMS
((const char *nullentry, const struct expression **pluralp,
unsigned long int *npluralsp)) internal_function;

#if !defined (_LIBC) && !defined (IN_LIBINTL)
extern unsigned long int plural_eval PARAMS ((struct expression *pexp,
extern unsigned long int plural_eval PARAMS ((const struct expression *pexp,
unsigned long int n));
#endif

Expand Down
6 changes: 4 additions & 2 deletions locale/programs/ld-collate.c
Expand Up @@ -990,7 +990,8 @@ insert_value (struct linereader *ldfile, const char *symstr, size_t symlen,
uint32_t wcs[2] = { wc, 0 };

/* We have to allocate an entry. */
elem = new_element (collate, seq != NULL ? seq->bytes : NULL,
elem = new_element (collate,
seq != NULL ? (char *) seq->bytes : NULL,
seq != NULL ? seq->nbytes : 0,
wc == ILLEGAL_CHAR_VALUE ? NULL : wcs,
symstr, symlen, 1);
Expand Down Expand Up @@ -1385,7 +1386,8 @@ order for `%.*s' already defined at %s:%Zu"),

/* We have to allocate an entry. */
elem = new_element (collate,
seq != NULL ? seq->bytes : NULL,
seq != NULL
? (char *) seq->bytes : NULL,
seq != NULL ? seq->nbytes : 0,
wc == ILLEGAL_CHAR_VALUE
? NULL : wcs, buf, lenfrom, 1);
Expand Down
10 changes: 6 additions & 4 deletions locale/programs/ld-ctype.c
Expand Up @@ -649,7 +649,8 @@ character <SP> not defined in character map")));
/* Find the UCS value for `bytes'. */
int inner;
uint32_t wch;
struct charseq *seq = charmap_find_symbol (charmap, bytes, nbytes);
struct charseq *seq
= charmap_find_symbol (charmap, (char *) bytes, nbytes);

if (seq == NULL)
wch = ILLEGAL_CHAR_VALUE;
Expand Down Expand Up @@ -750,7 +751,7 @@ character <SP> not defined in character map")));
for (cnt = 0; cnt < 10; ++cnt)
{
ctype->mbdigits[cnt] = charmap_find_symbol (charmap,
digits + cnt, 1);
(char *) digits + cnt, 1);
if (ctype->mbdigits[cnt] == NULL)
{
ctype->mbdigits[cnt] = charmap_find_symbol (charmap,
Expand Down Expand Up @@ -3470,7 +3471,8 @@ set_class_defaults (struct locale_ctype_t *ctype,
for (cnt = ctype->outdigits_act; cnt < 10; ++cnt)
{
ctype->mboutdigits[cnt] = charmap_find_symbol (charmap,
digits + cnt, 1);
(char *) digits + cnt,
1);

if (ctype->mboutdigits[cnt] == NULL)
ctype->mboutdigits[cnt] = charmap_find_symbol (charmap,
Expand Down Expand Up @@ -4025,7 +4027,7 @@ allocate_arrays (struct locale_ctype_t *ctype, const struct charmap_t *charmap,
int inner;
uint32_t wch;
struct charseq *seq =
charmap_find_symbol (charmap, bytes, nbytes);
charmap_find_symbol (charmap, (char *) bytes, nbytes);

if (seq == NULL)
wch = ILLEGAL_CHAR_VALUE;
Expand Down
6 changes: 3 additions & 3 deletions locale/programs/repertoire.c
@@ -1,4 +1,4 @@
/* Copyright (C) 1998-2002,2004,2005 Free Software Foundation, Inc.
/* Copyright (C) 1998-2002,2004,2005,2007 Free Software Foundation, Inc.
This file is part of the GNU C Library.
Contributed by Ulrich Drepper <drepper@cygnus.com>, 1998.
Expand Down Expand Up @@ -393,7 +393,7 @@ repertoire_new_char (struct linereader *lr, hash_table *ht, hash_table *rt,
const char *cp;
char *buf = NULL;
int prefix_len, len1, len2;
unsigned int from_nr, to_nr, cnt;
unsigned long int from_nr, to_nr, cnt;

if (to == NULL)
{
Expand Down Expand Up @@ -462,7 +462,7 @@ hexadecimal range format should use only capital characters"));
{
uint32_t this_value = value + (cnt - from_nr);

obstack_printf (ob, decimal_ellipsis ? "%.*s%0*d" : "%.*s%0*X",
obstack_printf (ob, decimal_ellipsis ? "%.*s%0*ld" : "%.*s%0*lX",
prefix_len, from, len1 - prefix_len, cnt);
obstack_1grow (ob, '\0');

Expand Down
4 changes: 2 additions & 2 deletions locale/weightwc.h
@@ -1,4 +1,4 @@
/* Copyright (C) 1996-2001,2003,2004,2005 Free Software Foundation, Inc.
/* Copyright (C) 1996-2001,2003,2004,2005,2007 Free Software Foundation, Inc.
This file is part of the GNU C Library.
Written by Ulrich Drepper, <drepper@cygnus.com>.
Expand Down Expand Up @@ -31,7 +31,7 @@ findidx (const wint_t **cpp)

/* Oh well, more than one sequence starting with this byte.
Search for the correct one. */
const int32_t *cp = &extra[-i];
const int32_t *cp = (const int32_t *) &extra[-i];
while (1)
{
size_t nhere;
Expand Down
2 changes: 1 addition & 1 deletion nis/nss_nis/nis-hosts.c
Expand Up @@ -88,7 +88,7 @@ LINE_PARSER
return 0;

/* Store a pointer to the address in the expected form. */
entdata->h_addr_ptrs[0] = entdata->host_addr;
entdata->h_addr_ptrs[0] = (char *) entdata->host_addr;
entdata->h_addr_ptrs[1] = NULL;
result->h_addr_list = entdata->h_addr_ptrs;

Expand Down
1 change: 1 addition & 0 deletions nptl/tst-locale2.c
Expand Up @@ -11,4 +11,5 @@ useless (void *a)
{
pthread_t th;
pthread_create (&th, 0, useless, a);
return NULL;
}
2 changes: 1 addition & 1 deletion nss/nss_files/files-hosts.c
Expand Up @@ -86,7 +86,7 @@ LINE_PARSER
result->h_length = af == AF_INET ? INADDRSZ : IN6ADDRSZ;

/* Store a pointer to the address in the expected form. */
entdata->h_addr_ptrs[0] = entdata->host_addr;
entdata->h_addr_ptrs[0] = (char *) entdata->host_addr;
entdata->h_addr_ptrs[1] = NULL;
result->h_addr_list = entdata->h_addr_ptrs;

Expand Down
4 changes: 2 additions & 2 deletions nss/nsswitch.c
Expand Up @@ -281,7 +281,7 @@ __nss_lookup_function (service_user *ni, const char *fct_name)
enough to a pointer to our structure to use as a lookup key that
will be passed to `known_compare' (above). */

found = __tsearch (&fct_name, (void **) &ni->known, &known_compare);
found = __tsearch (&fct_name, &ni->known, &known_compare);
if (*found != &fct_name)
/* The search found an existing structure in the tree. */
result = ((known_function *) *found)->fct_ptr;
Expand All @@ -298,7 +298,7 @@ __nss_lookup_function (service_user *ni, const char *fct_name)
remove_from_tree:
/* Oops. We can't instantiate this node properly.
Remove it from the tree. */
__tdelete (&fct_name, (void **) &ni->known, &known_compare);
__tdelete (&fct_name, &ni->known, &known_compare);
result = NULL;
}
else
Expand Down
5 changes: 3 additions & 2 deletions nss/nsswitch.h
@@ -1,4 +1,5 @@
/* Copyright (C) 1996-1999,2001,2002,2003,2004 Free Software Foundation, Inc.
/* Copyright (C) 1996-1999,2001,2002,2003,2004,2007
Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
Expand Down Expand Up @@ -66,7 +67,7 @@ typedef struct service_user
/* Link to the underlying library object. */
service_library *library;
/* Collection of known functions. */
struct entry *known;
void *known;
/* Name of the service (`files', `dns', `nis', ...). */
char name[0];
} service_user;
Expand Down
16 changes: 12 additions & 4 deletions posix/fnmatch.c
Expand Up @@ -351,10 +351,14 @@ fnmatch (pattern, string, flags)
already done? */
return -1;
if (p)
memset (&ps, '\0', sizeof (ps));
{
memset (&ps, '\0', sizeof (ps));
goto prepare_wpattern;
}
}
if (__builtin_expect (p != NULL, 0))
else
{
prepare_wpattern:
n = mbsrtowcs (NULL, &pattern, 0, &ps);
if (__builtin_expect (n == (size_t) -1, 0))
/* Something wrong.
Expand Down Expand Up @@ -383,10 +387,14 @@ fnmatch (pattern, string, flags)
already done? */
return -1;
if (p)
memset (&ps, '\0', sizeof (ps));
{
memset (&ps, '\0', sizeof (ps));
goto prepare_wstring;
}
}
if (__builtin_expect (p != NULL, 0))
else
{
prepare_wstring:
n = mbsrtowcs (NULL, &string, 0, &ps);
if (__builtin_expect (n == (size_t) -1, 0))
/* Something wrong.
Expand Down
2 changes: 1 addition & 1 deletion posix/runtests.c
Expand Up @@ -36,7 +36,7 @@ struct a_test
{
int expected;
const char * pattern;
const unsigned char * data;
const char * data;
};

static const struct a_test the_tests[] =
Expand Down

0 comments on commit 701666b

Please sign in to comment.