Skip to content

Commit

Permalink
* Makeconfig: Define pie-ccflag and PIE-ccflag variables.
Browse files Browse the repository at this point in the history
	* elf/Makefile: Use pie-ccflag variable.
	* nscd/Makefile: Likewise.
	* sysdeps/sparc/Makefile: Set $(pie-ccflag) to -fPIE.
  • Loading branch information
Ulrich Drepper committed Jul 26, 2008
1 parent 3f41492 commit 7b91359
Show file tree
Hide file tree
Showing 7 changed files with 18 additions and 5 deletions.
7 changes: 7 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
2008-07-24 Tom "spot" Callaway <tcallawa@redhat.com>

* Makeconfig: Define pie-ccflag and PIE-ccflag variables.
* elf/Makefile: Use pie-ccflag variable.
* nscd/Makefile: Likewise.
* sysdeps/sparc/Makefile: Set $(pie-ccflag) to -fPIE.

2008-07-21 Andreas Krebbel <krebbel1@de.ibm.com>

[BZ #6724]
Expand Down
4 changes: 4 additions & 0 deletions Makeconfig
Original file line number Diff line number Diff line change
Expand Up @@ -712,6 +712,10 @@ pic-ccflag = -fPIC
# This one should always stay like this unless there is a very good reason.
PIC-ccflag = -fPIC
endif
# This can be changed by a sysdep makefile
pie-ccflag = -fpie
# This one should always stay like this unless there is a very good reason.
PIE-ccflag = -fPIE
ifeq (yes,$(build-profile))
# Under --enable-profile, we will build a static library of profiled objects.
# The profiled object files are named foo.op.
Expand Down
2 changes: 1 addition & 1 deletion elf/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -800,7 +800,7 @@ $(objpfx)tst-array5-static.out: $(objpfx)tst-array5-static
cmp $@ tst-array5-static.exp > /dev/null

ifeq (yesyes,$(have-fpie)$(build-shared))
CFLAGS-tst-pie1.c += -fpie
CFLAGS-tst-pie1.c += $(pie-ccflag)

$(objpfx)tst-pie1.out: $(objpfx)tst-pie1
$(elf-objpfx)$(rtld-installed-name) \
Expand Down
4 changes: 2 additions & 2 deletions elf/dl-object.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* Storage management for the chain of loaded shared objects.
Copyright (C) 1995-2002, 2004, 2006, 2007 Free Software Foundation, Inc.
Copyright (C) 1995-2002,2004,2006,2007,2008 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
Expand Down Expand Up @@ -50,7 +50,7 @@ _dl_new_object (char *realname, const char *libname, int type,
#endif

new = (struct link_map *) calloc (sizeof (*new) + audit_space
+ sizeof (struct r_scope_elem)
+ sizeof (struct link_map *)
+ sizeof (*newname) + libname_len, 1);
if (new == NULL)
return NULL;
Expand Down
2 changes: 1 addition & 1 deletion nptl/sysdeps/unix/sysv/linux/mq_notify.c
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ init_mq_netlink (void)
if (netlink_socket == -1)
{
/* Just a normal netlink socket, not bound. */
if (have_sock_cloexec)
if (have_sock_cloexec >= 0)
{
netlink_socket = socket (AF_NETLINK, SOCK_RAW | SOCK_CLOEXEC, 0);
#if defined SOCK_CLOEXEC && !defined __ASSUME_SOCK_CLOEXEC
Expand Down
2 changes: 1 addition & 1 deletion nscd/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ CFLAGS-nscd_initgroups.c = -fexceptions

nscd-cflags = -DIS_IN_nscd=1 -D_FORTIFY_SOURCE=2
ifeq (yesyes,$(have-fpie)$(build-shared))
nscd-cflags += -fpie
nscd-cflags += $(pie-ccflag)
endif
ifeq (yes,$(have-ssp))
nscd-cflags += -fstack-protector
Expand Down
2 changes: 2 additions & 0 deletions sysdeps/sparc/Makefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# The Sparc `long double' is a distinct type we support.
long-double-fcts = yes

pie-ccflag = -fPIE

ifeq ($(subdir),gmon)
sysdep_routines += sparc-mcount
endif
Expand Down

0 comments on commit 7b91359

Please sign in to comment.