Skip to content

Commit

Permalink
Fix ldconfig to handle symlinks in chroot correctly.
Browse files Browse the repository at this point in the history
  • Loading branch information
Ulrich Drepper committed May 3, 2010
1 parent f297602 commit 7dee266
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 1 deletion.
3 changes: 3 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
2010-05-03 Ulrich Drepper <drepper@redhat.com>

[BZ #11149]
* elf/ldconfig.c (search_dir): Fix handling of symlinks in chroot.

* elf/chroot_canon.c (chroot_canon): Use xmalloc and xrealloc.

* elf/ldconfig.c (parse_conf_include): Don't fall back to
Expand Down
13 changes: 12 additions & 1 deletion elf/ldconfig.c
Original file line number Diff line number Diff line change
Expand Up @@ -773,7 +773,18 @@ search_dir (const struct dir_entry *entry)
{
/* In case of symlink, we check if the symlink refers to
a directory. */
if (__builtin_expect (stat64 (real_file_name, &stat_buf), 0))
char *target_name = real_file_name;
if (opt_chroot)
{
target_name = chroot_canon (opt_chroot, file_name);
if (target_name == NULL)
{
if (strstr (file_name, ".so") == NULL)
error (0, 0, _("Input file %s not found.\n"), file_name);
continue;
}
}
if (__builtin_expect (stat64 (target_name, &stat_buf), 0))
{
if (opt_verbose)
error (0, errno, _("Cannot stat %s"), file_name);
Expand Down

0 comments on commit 7dee266

Please sign in to comment.