Skip to content

Commit

Permalink
* sysdeps/unix/sysv/linux/timer_routines.c (timer_helper_thread):
Browse files Browse the repository at this point in the history
	Use __sigfillset.  Document that sigfillset does the right thing wrt
	to SIGSETXID.
  • Loading branch information
Ulrich Drepper committed Aug 24, 2005
1 parent 2c210d1 commit 8558d71
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
4 changes: 3 additions & 1 deletion nptl/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
2005-08-23 Ulrich Drepper <drepper@redhat.com>

* sysdeps/unix/sysv/linux/timer_routines.c: Don't block SIGSETXID ever.
* sysdeps/unix/sysv/linux/timer_routines.c (timer_helper_thread):
Use __sigfillset. Document that sigfillset does the right thing wrt
to SIGSETXID.

2005-07-11 Jakub Jelinek <jakub@redhat.com>

Expand Down
9 changes: 2 additions & 7 deletions nptl/sysdeps/unix/sysv/linux/timer_routines.c
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,6 @@ timer_helper_thread (void *arg)
sigset_t ss;
sigemptyset (&ss);
__sigaddset (&ss, SIGTIMER);
#ifdef SIGSETXID
__sigaddset (&ss, SIGSETXID);
#endif

/* Endless loop of waiting for signals. The loop is only ended when
the thread is canceled. */
Expand Down Expand Up @@ -128,14 +125,12 @@ __start_helper_thread (void)
/* Block all signals in the helper thread but SIGSETXID. To do this
thoroughly we temporarily have to block all signals here. The
helper can lose wakeups if SIGCANCEL is not blocked throughout,
but sigfillset omits it. So, we add it back explicitly here. */
but sigfillset omits it SIGSETXID. So, we add SIGCANCEL back
explicitly here. */
sigset_t ss;
sigset_t oss;
sigfillset (&ss);
__sigaddset (&ss, SIGCANCEL);
#ifdef SIGSETXID
__sigdelset (&ss, SIGSETXID);
#endif
INTERNAL_SYSCALL_DECL (err);
INTERNAL_SYSCALL (rt_sigprocmask, err, 4, SIG_SETMASK, &ss, &oss, _NSIG / 8);

Expand Down

0 comments on commit 8558d71

Please sign in to comment.