Skip to content

Commit

Permalink
Add more headers to include/ for conform tests.
Browse files Browse the repository at this point in the history
Carlos reported failures in conform/ tests in environments where the
compiler used could only find headers in glibc's source and build
trees, not any previously installed headers
<https://sourceware.org/ml/libc-alpha/2014-09/msg00040.html>.

This patch adds wrappers for two of the affected headers to include/,
which is the normal way to make headers visible when building or
testing in directories other than the one containing the header (I
suppose these headers weren't needed in any such directories except
conform/, or other build or test failures would have resulted).  I
believe the same issue applies at least to regexp.h and re_comp.h - we
don't currently have conform/ expectations for those, but when such
expectations are added we'll also need to add header wrappers.

Tested for x86_64 (testsuite, and that installed stripped shared
libraries are unchanged by the patch).  I did *not* test a
configuration such as that in which Carlos saw failure.

	* include/cpio.h: New file.
	* include/fmtmsg.h: Likewise.
  • Loading branch information
Joseph Myers committed Dec 11, 2014
1 parent 47d51f4 commit a1edbf3
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 0 deletions.
3 changes: 3 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
2014-12-11 Joseph Myers <joseph@codesourcery.com>

* include/cpio.h: New file.
* include/fmtmsg.h: Likewise.

* tst-mbswcs1.c (show): Use %zu format instead of %Zd. Cast
corresponding format argument to size_t.
* tst-mbswcs2.c (show): Likewise. Use %td format for ptrdiff_t
Expand Down
1 change: 1 addition & 0 deletions include/cpio.h
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
#include <posix/cpio.h>
1 change: 1 addition & 0 deletions include/fmtmsg.h
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
#include <stdlib/fmtmsg.h>

0 comments on commit a1edbf3

Please sign in to comment.