Skip to content

Commit

Permalink
test-skeleton: increase default TIMEOUT to 20 seconds
Browse files Browse the repository at this point in the history
The vast majority of timeouts I've seen w/glibc tests are due to:
 - slow system (e.g. <1 GHz cpu)
 - loaded system (e.g. lots of parallelism)
Even then, I've seen timeouts on system I don't generally consider
slow, or even loaded, and considering TIMEOUT is set to <=10 in ~60
tests (and <=20 in ~75 tests), it seems I'm not alone.  I've just
gotten in the habit of doing `export TIMEOUTFACTOR=10` on all my
setups.

In the edge case where there is a bug in the test and the timeout is
hit, I think we all agree that's either a problem with the test or a
real bug in the library somewhere.  In either case, the incident rate
should be low, so catering to that seems like the wrong trade-off.

Other developers too usually set large timeout factors.  Increase the
default to 20 seconds to match reality.
  • Loading branch information
Mike Frysinger committed Feb 19, 2016
1 parent b6ebba7 commit a28605b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
4 changes: 4 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
2016-02-19 Mike Frysinger <vapier@gentoo.org>

* test-skeleton.c (TIMEOUT): Change to 20 and adjust comment.

2016-02-19 Carlos O'Donell <carlos@systemhalted.org>

* nptl/allocatestack.c (allocate_stack): Declare new stackaddr,
Expand Down
5 changes: 3 additions & 2 deletions test-skeleton.c
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,9 @@
#endif

#ifndef TIMEOUT
/* Default timeout is two seconds. */
# define TIMEOUT 2
/* Default timeout is twenty seconds. Tests should normally complete faster
than this, but if they don't, that's abnormal (a bug) anyways. */
# define TIMEOUT 20
#endif

#define OPT_DIRECT 1000
Expand Down

0 comments on commit a28605b

Please sign in to comment.