Skip to content

Commit

Permalink
Fix __ASSUME_PSELECT for MicroBlaze (bug 16642).
Browse files Browse the repository at this point in the history
Reviewing (for all architectures, with a baseline kernel version of
2.6.32) the kernel support for features for which __ASSUME_* macros
would be affected by a move to 2.6.32 as minimum kernel version showed
up that __ASSUME_PSELECT was wrongly defined for MicroBlaze, despite
the corresponding syscall table entry not being wired up in the
MicroBlaze kernel.

This patch makes the MicroBlaze kernel-features.h undefine
__ASSUME_PSELECT.  I'd also encourage wiring it up in the kernel (so
you can then make this #undef conditional, and eventually obsolete
once a recent-enough kernel is required).  I suspect it wasn't wired
up because of the mistaken comment in asm/unistd.h "obsolete ->
sys_pselect7" (there is no such syscall as pselect7).

	[BZ #16642]
	* sysdeps/unix/sysv/linux/microblaze/kernel-features.h
	(__ASSUME_PSELECT): Undefine.
  • Loading branch information
Joseph Myers committed Mar 12, 2014
1 parent dd3946c commit abe6d90
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
6 changes: 6 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
2014-03-12 Joseph Myers <joseph@codesourcery.com>

[BZ #16642]
* sysdeps/unix/sysv/linux/microblaze/kernel-features.h
(__ASSUME_PSELECT): Undefine.

2014-03-12 Adhemerval Zanella <azanella@linux.vnet.ibm.com>

[BZ #16689]
Expand Down
4 changes: 2 additions & 2 deletions NEWS
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ Version 2.20
* The following bugs are resolved with this release:

15347, 15804, 15894, 16447, 16532, 16545, 16574, 16600, 16609, 16610,
16611, 16613, 16623, 16632, 16639, 16670, 16674, 16677, 16683, 16689,
16695.
16611, 16613, 16623, 16632, 16639, 16642, 16670, 16674, 16677, 16683,
16689, 16695.

* The am33 port, which had not worked for several years, has been removed
from ports.
Expand Down
3 changes: 3 additions & 0 deletions sysdeps/unix/sysv/linux/microblaze/kernel-features.h
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,6 @@
#endif

#include_next <kernel-features.h>

/* The MicroBlaze kernel does not support the pselect6 syscall. */
#undef __ASSUME_PSELECT

0 comments on commit abe6d90

Please sign in to comment.