Skip to content

Commit

Permalink
Fix possibly uninitilized variable handling.
Browse files Browse the repository at this point in the history
If malloc errors are ignored (which say aren't by default and never
should be) malloc in the old, slow form might use an uninitialized
variable.
  • Loading branch information
Ulrich Drepper committed Apr 9, 2010
1 parent 59d9f1d commit ad3d3e8
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
5 changes: 5 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
2010-04-08 Ulrich Drepper <drepper@redhat.com>

* malloc/malloc.c (_int_malloc): Return NULL if printing error message
returns.

2010-03-30 Daniel Jacobowitz <dan@codesourcery.com>

* Makeconfig (+common-includes): Define.
Expand Down
1 change: 1 addition & 0 deletions malloc/malloc.c
Original file line number Diff line number Diff line change
Expand Up @@ -4306,6 +4306,7 @@ _int_malloc(mstate av, size_t bytes)
errstr = "malloc(): memory corruption (fast)";
errout:
malloc_printerr (check_action, errstr, chunk2mem (victim));
return NULL;
}
#ifndef ATOMIC_FASTBINS
*fb = victim->fd;
Expand Down

0 comments on commit ad3d3e8

Please sign in to comment.