Skip to content

Commit

Permalink
[BZ #5774]
Browse files Browse the repository at this point in the history
	* stdlib/strtod_l.c (____STRTOF_INTERNAL): Consume closing brace
	on NAN(...) sequence.
	* stdlib/Makefile (tests): Add tst-strtod6.
	* stdlib/tst-strtod6.c: New file.

	* inet/inet6_opt.c (inet6_opt_init): Check extlen for overflow.
  • Loading branch information
Ulrich Drepper committed Mar 8, 2008
1 parent 2127a18 commit b327855
Show file tree
Hide file tree
Showing 5 changed files with 66 additions and 2 deletions.
8 changes: 8 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
2008-03-08 Ulrich Drepper <drepper@redhat.com>

[BZ #5774]
* stdlib/strtod_l.c (____STRTOF_INTERNAL): Consume closing brace
on NAN(...) sequence.
* stdlib/Makefile (tests): Add tst-strtod6.
* stdlib/tst-strtod6.c: New file.

* inet/inet6_opt.c (inet6_opt_init): Check extlen for overflow.

[BZ #5762]
* posix/getopt.c (_getopt_internal_r): Clarify error message by
putting offending option character in quotes. Clean up error
Expand Down
2 changes: 1 addition & 1 deletion inet/inet6_opt.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ inet6_opt_init (void *extbuf, socklen_t extlen)
{
if (extbuf != NULL)
{
if (extlen <= 0 || (extlen % 8) != 0)
if (extlen <= 0 || (extlen % 8) != 0 || extlen > 256 * 8)
return -1;

/* Fill in the length in units of 8 octets. */
Expand Down
2 changes: 1 addition & 1 deletion stdlib/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ tests := tst-strtol tst-strtod testmb testrand testsort testdiv \
test-a64l tst-qsort tst-system testmb2 bug-strtod2 \
tst-atof1 tst-atof2 tst-strtod2 tst-strtod3 tst-rand48-2 \
tst-makecontext tst-strtod4 tst-strtod5 tst-qsort2 \
tst-makecontext2
tst-makecontext2 tst-strtod6

include ../Makeconfig

Expand Down
3 changes: 3 additions & 0 deletions stdlib/strtod_l.c
Original file line number Diff line number Diff line change
Expand Up @@ -594,6 +594,9 @@ ____STRTOF_INTERNAL (nptr, endptr, group, loc)
mant = STRTOULL (startp + 1, &endp, 0);
if (endp == cp)
SET_MANTISSA (retval, mant);

/* Consume the closing brace. */
++cp;
}
}

Expand Down
53 changes: 53 additions & 0 deletions stdlib/tst-strtod6.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
#include <math.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>

static int
do_test (void)
{
static const char str[] = "NaN(blabla)something";
char *endp;
int result = 0;

double d = strtod (str, &endp);
if (!isnan (d))
{
puts ("strtod did not return NAN");
result = 1;
}
if (strcmp (endp, "something") != 0)
{
puts ("strtod set incorrect end pointer");
result = 1;
}

float f = strtof (str, &endp);
if (!isnanf (f))
{
puts ("strtof did not return NAN");
result = 1;
}
if (strcmp (endp, "something") != 0)
{
puts ("strtof set incorrect end pointer");
result = 1;
}

long double ld = strtold (str, &endp);
if (!isnan (ld))
{
puts ("strtold did not return NAN");
result = 1;
}
if (strcmp (endp, "something") != 0)
{
puts ("strtold set incorrect end pointer");
result = 1;
}

return result;
}

#define TEST_FUNCTION do_test ()
#include "../test-skeleton.c"

0 comments on commit b327855

Please sign in to comment.