Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Cache the host port like we cache the task port
This way we do not
need to call the kernel just to get the port.  Furthermore, we no
longer increase the reference count on every invocation of
`mach_host_self'.

* mach/mach/mach_traps.h (__mach_host_self, mach_host_self):
Protect declarations against the macro expansion.
* mach/mach_init.c (__mach_host_self_): New variable.
(mach_init): Initialize `__mach_host_self_'.
* mach/mach_init.h (__mach_host_self_): New declaration.
(__mach_host_self, mach_host_self): New macros.
* sysdeps/mach/hurd/dl-sysdep.c (_dl_sysdep_start_cleanup):
Release reference.
  • Loading branch information
Justus Winter authored and Samuel Thibault committed Sep 16, 2015
1 parent c88b3da commit bb95a72
Show file tree
Hide file tree
Showing 5 changed files with 28 additions and 3 deletions.
16 changes: 16 additions & 0 deletions ChangeLog
@@ -1,3 +1,19 @@
2015-09-16 Justus Winter <4winter@informatik.uni-hamburg.de>

Cache the host port like we cache the task port. This way we do not
need to call the kernel just to get the port. Furthermore, we no
longer increase the reference count on every invocation of
`mach_host_self'.

* mach/mach/mach_traps.h (__mach_host_self, mach_host_self):
Protect declarations against the macro expansion.
* mach/mach_init.c (__mach_host_self_): New variable.
(mach_init): Initialize `__mach_host_self_'.
* mach/mach_init.h (__mach_host_self_): New declaration.
(__mach_host_self, mach_host_self): New macros.
* sysdeps/mach/hurd/dl-sysdep.c (_dl_sysdep_start_cleanup):
Release reference.

2015-09-16 Joseph Myers <joseph@codesourcery.com>

[BZ #4404]
Expand Down
7 changes: 4 additions & 3 deletions mach/mach/mach_traps.h
Expand Up @@ -41,9 +41,10 @@ extern mach_port_t __mach_thread_self (void);
extern mach_port_t (mach_task_self) (void);
extern mach_port_t (__mach_task_self) (void);

/* Return the host information port for the host of the calling task. */
extern mach_port_t mach_host_self (void);
extern mach_port_t __mach_host_self (void);
/* Return the host information port for the host of the calling task.
The parens are needed to protect against the macro in <mach_init.h>. */
extern mach_port_t (mach_host_self) (void);
extern mach_port_t (__mach_host_self) (void);

/* Attempt to context switch the current thread off the processor. Returns
true if there are other threads that can be run and false if not. */
Expand Down
2 changes: 2 additions & 0 deletions mach/mach_init.c
Expand Up @@ -20,6 +20,7 @@
#include <unistd.h>

mach_port_t __mach_task_self_;
mach_port_t __mach_host_self_;
vm_size_t __vm_page_size = 0; /* Must be data not bss for weak alias. */
weak_alias (__vm_page_size, vm_page_size)

Expand All @@ -34,6 +35,7 @@ __mach_init (void)
kern_return_t err;

__mach_task_self_ = (__mach_task_self) ();
__mach_host_self_ = (__mach_host_self) ();
__mig_init (0);

#ifdef HAVE_HOST_PAGE_SIZE
Expand Down
5 changes: 5 additions & 0 deletions mach/mach_init.h
Expand Up @@ -31,6 +31,11 @@ extern mach_port_t __mach_task_self_;
#define __mach_task_self() (__mach_task_self_ + 0) /* Not an lvalue. */
#define mach_task_self() (__mach_task_self ())

/* This cache is initialized at startup. */
extern mach_port_t __mach_host_self_;
#define __mach_host_self() (__mach_host_self_ + 0) /* Not an lvalue. */
#define mach_host_self() (__mach_host_self ())

/* Kernel page size. */
extern vm_size_t __vm_page_size;
extern vm_size_t vm_page_size;
Expand Down
1 change: 1 addition & 0 deletions sysdeps/mach/hurd/dl-sysdep.c
Expand Up @@ -279,6 +279,7 @@ _dl_sysdep_start_cleanup (void)
__mach_init. We are done with them now, and the user will
reacquire them for himself when he wants them. */
__mig_dealloc_reply_port (MACH_PORT_NULL);
__mach_port_deallocate (__mach_task_self (), __mach_host_self_);
__mach_port_deallocate (__mach_task_self (), __mach_task_self_);
}

Expand Down

0 comments on commit bb95a72

Please sign in to comment.