Skip to content

Commit

Permalink
* elf/dl-load.c (_dl_map_object_from_fd): Move state change
Browse files Browse the repository at this point in the history
	notification...
	(lose): ...to here.
  • Loading branch information
Ulrich Drepper committed Apr 30, 2006
1 parent 846d136 commit bca2218
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 11 deletions.
4 changes: 4 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
2006-04-30 Ulrich Drepper <drepper@redhat.com>

* elf/dl-load.c (_dl_map_object_from_fd): Move state change
notification...
(lose): ...to here.

* posix/Makefile (tests): Add tst-getaddrinfo3.
* posix/tst-getaddrinfo3.c: New file.

Expand Down
23 changes: 12 additions & 11 deletions elf/dl-load.c
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
/* Map in a shared object's segments from the file.
Copyright (C) 1995, 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004,
2005, 2006 Free Software Foundation, Inc.
Copyright (C) 1995-2005, 2006 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
Expand Down Expand Up @@ -786,7 +785,7 @@ _dl_init_paths (const char *llp)
static void
__attribute__ ((noreturn, noinline))
lose (int code, int fd, const char *name, char *realname, struct link_map *l,
const char *msg)
const char *msg, struct r_debug *r)
{
/* The file might already be closed. */
if (fd != -1)
Expand All @@ -805,6 +804,13 @@ lose (int code, int fd, const char *name, char *realname, struct link_map *l,
free (l);
}
free (realname);

if (r != NULL)
{
r->r_state = RT_CONSISTENT;
_dl_debug_state ();
}

_dl_signal_error (code, name, NULL, msg);
}

Expand Down Expand Up @@ -840,13 +846,8 @@ _dl_map_object_from_fd (const char *name, int fd, struct filebuf *fbp,
call_lose_errno:
errval = errno;
call_lose:
if (make_consistent)
{
r->r_state = RT_CONSISTENT;
_dl_debug_state ();
}

lose (errval, fd, name, realname, l, errstring);
lose (errval, fd, name, realname, l, errstring,
make_consistent ? r : NULL);
}

/* Look again to see if the real name matched another already loaded. */
Expand Down Expand Up @@ -1642,7 +1643,7 @@ open_verify (const char *name, struct filebuf *fbp, struct link_map *loader,
name = strdupa (realname);
free (realname);
}
lose (errval, fd, name, NULL, NULL, errstring);
lose (errval, fd, name, NULL, NULL, errstring, NULL);
}

/* See whether the ELF header is what we expect. */
Expand Down

0 comments on commit bca2218

Please sign in to comment.