Skip to content

Commit

Permalink
Do not use -Wno-strict-prototypes.
Browse files Browse the repository at this point in the history
Two glibc makefiles use -Wno-strict-prototypes.  I don't know if this
was needed before my recent conversion of many function definitions to
prototype style, but it's not needed now; this patch removes it.

Tested for x86_64 and x86 (testsuite, and that installed stripped
shared libraries are unchanged by the patch).

	* posix/Makefile (CFLAGS-regex.c): Remove variable.
	* resolv/Makefile (+cflags): Do not use -Wno-strict-prototypes.
  • Loading branch information
Joseph Myers committed Oct 19, 2015
1 parent f63f2bf commit d10a3ab
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
3 changes: 3 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
2015-10-19 Joseph Myers <joseph@codesourcery.com>

* posix/Makefile (CFLAGS-regex.c): Remove variable.
* resolv/Makefile (+cflags): Do not use -Wno-strict-prototypes.

* crypt/crypt-entry.c (__crypt_r): Convert to prototype-style
function definition.
* crypt/crypt_util.c (__encrypt_r): Likewise.
Expand Down
1 change: 0 additions & 1 deletion posix/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,6 @@ $(objpfx)config-name.h: $(..)scripts/config-uname.sh $(common-objpfx)config.make
'$(config-machine)-$(config-vendor)' > $@.new
mv -f $@.new $@

CFLAGS-regex.c = -Wno-strict-prototypes
CFLAGS-getaddrinfo.c = -DRESOLVER -fexceptions
CFLAGS-pause.c = -fexceptions -fasynchronous-unwind-tables
CFLAGS-pread.c = -fexceptions -fasynchronous-unwind-tables
Expand Down
2 changes: 1 addition & 1 deletion resolv/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ CFLAGS-libresolv += $(stack-protector)
CFLAGS-res_hconf.c = -fexceptions

# The BIND code elicits some harmless warnings.
+cflags += -Wno-strict-prototypes -Wno-write-strings
+cflags += -Wno-write-strings

# The DNS NSS modules needs the resolver.
$(objpfx)libnss_dns.so: $(objpfx)libresolv.so
Expand Down

0 comments on commit d10a3ab

Please sign in to comment.