Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Replace __attribute__((visibility("protected")))
With copy relocation, address of protected data defined in the shared
library may be external.  Compiler shouldn't asssume protected data will
be local.  But due to

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65248

__attribute__((visibility("protected"))) doesn't work correctly, we need
to use asm (".protected xxx") instead.

	* elf/ifuncdep2.c (global): Replace
	__attribute__((visibility("protected"))) with
	asm (".protected global").
	* elf/ifuncmod1.c (global): Likewise.
	* elf/ifuncmod5.c (global): Likewise.
  • Loading branch information
H.J. Lu committed Mar 7, 2015
1 parent 0b3467b commit e0ed2fb
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 3 deletions.
8 changes: 8 additions & 0 deletions ChangeLog
@@ -1,3 +1,11 @@
2015-03-06 H.J. Lu <hongjiu.lu@intel.com>

* elf/ifuncdep2.c (global): Replace
__attribute__((visibility("protected"))) with
asm (".protected global").
* elf/ifuncmod1.c (global): Likewise.
* elf/ifuncmod5.c (global): Likewise.

2015-03-06 Joseph Myers <joseph@codesourcery.com>

* soft-fp/soft-fp.h [!_LIBC && __KERNEL__]: Include
Expand Down
8 changes: 7 additions & 1 deletion elf/ifuncdep2.c
Expand Up @@ -2,7 +2,13 @@

#include "ifunc-sel.h"

int global __attribute__ ((visibility ("protected"))) = -1;
int global = -1;
/* Can't use __attribute__((visibility("protected"))) until the GCC bug:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65248
is fixed. */
asm (".protected global");

static int
one (void)
Expand Down
8 changes: 7 additions & 1 deletion elf/ifuncmod1.c
Expand Up @@ -6,7 +6,13 @@
*/
#include "ifunc-sel.h"

int global __attribute__ ((visibility ("protected"))) = -1;
int global = -1;
/* Can't use __attribute__((visibility("protected"))) until the GCC bug:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65248
is fixed. */
asm (".protected global");

static int
one (void)
Expand Down
8 changes: 7 additions & 1 deletion elf/ifuncmod5.c
@@ -1,7 +1,13 @@
/* Test STT_GNU_IFUNC symbols without direct function call. */
#include "ifunc-sel.h"

int global __attribute__ ((visibility ("protected"))) = -1;
int global = -1;
/* Can't use __attribute__((visibility("protected"))) until the GCC bug:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65248
is fixed. */
asm (".protected global");

static int
one (void)
Expand Down

0 comments on commit e0ed2fb

Please sign in to comment.