Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Prefer real syscalls instead of vsyscalls on x86-64 outside libc.so
  • Loading branch information
Ulrich Drepper committed Sep 6, 2011
1 parent 6585cb6 commit ef60624
Show file tree
Hide file tree
Showing 5 changed files with 38 additions and 3 deletions.
10 changes: 10 additions & 0 deletions ChangeLog
@@ -1,3 +1,13 @@
2011-09-06 Ulrich Drepper <drepper@gmail.com>

* sysdeps/unix/sysv/linux/kernel-features.h: Add entry for getcpu
syscall on x86-64.
* sysdeps/unix/sysv/linux/x86_64/gettimeofday.c [!SHARED]: Use real
syscall.
* sysdeps/unix/sysv/linux/x86_64/time.c: Likewise.
* sysdeps/unix/sysv/linux/x86_64/sched_getcpu.S [!SHARED]: Use real
syscall if possible.

2011-09-05 Ulrich Drepper <drepper@gmail.com>

* elf/pldd.c (get_process_info): Don't read whole ELF header, just
Expand Down
5 changes: 5 additions & 0 deletions sysdeps/unix/sysv/linux/kernel-features.h
Expand Up @@ -546,3 +546,8 @@
#if __LINUX_KERNEL_VERSION >= 0x020627
# define __ASSUME_SENDMMSG 1
#endif

/* getcpu is a syscall for x86-64 since 3.1. */
#if defined __x86_64__ && __LINUX_KERNEL_VERSION >= 0x030100
# define __ASSUME_GETCPU_SYSCALL 1
#endif
3 changes: 2 additions & 1 deletion sysdeps/unix/sysv/linux/x86_64/gettimeofday.c
Expand Up @@ -37,11 +37,12 @@ gettimeofday_ifunc (void)
__asm (".type __gettimeofday, %gnu_indirect_function");
#else
# include <sys/time.h>
# include <sysdep.h>

int
__gettimeofday (struct timeval *tv, struct timezone *tz)
{
return ((int (*) (struct timeval *, struct timezone *)) VSYSCALL_ADDR_vgettimeofday) (tv, tz);
return INLINE_SYSCALL (gettimeofday, 2, tv, tz);
}
#endif

Expand Down
19 changes: 18 additions & 1 deletion sysdeps/unix/sysv/linux/x86_64/sched_getcpu.S
Expand Up @@ -20,6 +20,7 @@
#include <tls.h>
#define _ERRNO_H 1
#include <bits/errno.h>
#include <kernel-features.h>

/* For the calculation see asm/vsyscall.h. */
#define VSYSCALL_ADDR_vgetcpu 0xffffffffff600800
Expand All @@ -38,10 +39,26 @@ ENTRY (sched_getcpu)
#ifdef SHARED
movq __vdso_getcpu(%rip), %rax
PTR_DEMANGLE (%rax)
callq *%rax
#else
# ifdef __NR_getcpu
movl $__NR_getcpu, %eax
syscall
# ifndef __ASSUME_GETCPU_SYSCALL
cmpq $-ENOSYS, %rax
jne 1f
# endif
# endif
# ifndef __ASSUME_GETCPU_SYSCALL
movq $VSYSCALL_ADDR_vgetcpu, %rax
#endif
callq *%rax
1:
# else
# ifndef __NR_getcpu
# error "cannot happen"
# endif
# endif
#endif

cmpq $-4095, %rax
jae SYSCALL_ERROR_LABEL
Expand Down
4 changes: 3 additions & 1 deletion sysdeps/unix/sysv/linux/x86_64/time.c
Expand Up @@ -36,11 +36,13 @@ time_ifunc (void)
__asm (".type time, %gnu_indirect_function");
#else
# include <time.h>
# include <sysdep.h>

time_t
time (time_t *t)
{
return ((time_t (*) (time_t *)) VSYSCALL_ADDR_vtime) (t);
INTERNAL_SYSCALL_DECL (err);
return INTERNAL_SYSCALL (time, err, 1, t);
}
#endif

Expand Down

0 comments on commit ef60624

Please sign in to comment.