Skip to content

Commit

Permalink
Update.
Browse files Browse the repository at this point in the history
	* intl/finddomain.c (_nl_find_domain): Protect calls to
	_nl_make_l10nflist.
  • Loading branch information
Ulrich Drepper committed Sep 26, 2004
1 parent 4faf24a commit f6b90f4
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
3 changes: 3 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
2004-09-25 Ulrich Drepper <drepper@redhat.com>

* intl/finddomain.c (_nl_find_domain): Protect calls to
_nl_make_l10nflist.

* sysdeps/posix/getaddrinfo.c (getaddrinfo): If determinination of
source address fails, initialized source_addr_len field so that
duplicate address recognition does not copy junk.
Expand Down
13 changes: 13 additions & 0 deletions intl/finddomain.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
#include "gettextP.h"
#ifdef _LIBC
# include <libintl.h>
# include <bits/libc-lock.h>
#else
# include "libgnuintl.h"
#endif
Expand Down Expand Up @@ -78,11 +79,17 @@ _nl_find_domain (dirname, locale, domainname, domainbinding)
(4) modifier
*/

/* We need to protect modifying the _NL_LOADED_DOMAINS data. */
__libc_lock_define_initialized (static, lock);
__libc_lock_lock (lock);

/* If we have already tested for this locale entry there has to
be one data set in the list of loaded domains. */
retval = _nl_make_l10nflist (&_nl_loaded_domains, dirname,
strlen (dirname) + 1, 0, locale, NULL, NULL,
NULL, NULL, domainname, 0);
__libc_lock_unlock (lock);

if (retval != NULL)
{
/* We know something about this locale. */
Expand All @@ -102,6 +109,7 @@ _nl_find_domain (dirname, locale, domainname, domainbinding)
if (retval->successor[cnt]->data != NULL)
break;
}

return cnt >= 0 ? retval : NULL;
/* NOTREACHED */
}
Expand Down Expand Up @@ -132,12 +140,17 @@ _nl_find_domain (dirname, locale, domainname, domainbinding)
mask = _nl_explode_name (locale, &language, &modifier, &territory,
&codeset, &normalized_codeset);

/* We need to protect modifying the _NL_LOADED_DOMAINS data. */
__libc_lock_lock (lock);

/* Create all possible locale entries which might be interested in
generalization. */
retval = _nl_make_l10nflist (&_nl_loaded_domains, dirname,
strlen (dirname) + 1, mask, language, territory,
codeset, normalized_codeset, modifier,
domainname, 1);
__libc_lock_unlock (lock);

if (retval == NULL)
/* This means we are out of core. */
return NULL;
Expand Down

0 comments on commit f6b90f4

Please sign in to comment.