Skip to content

Conversation

@renewiegandt
Copy link
Collaborator

Solves #74 and update old parameter names in config files and pipeline.

Copy link
Collaborator

@HendrikSchultheis HendrikSchultheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice quality of life improvements.

motif_min_len = 8
motif_max_len = 20
interation = 10000
motif_min_key = 8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think motif_min_len was more obvious in it's meaning.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but the parameter sets the number of minimum key positions not the length of the motif.

@renewiegandt renewiegandt merged commit 987bf7f into dev Jan 23, 2019
Sign in to join this conversation on GitHub.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants