Fix funny filenames #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `read -r` to avoid interpreting backslash when reading the file list.
|
Thank you for fixing this. Two nits in the commit message:
components and trailing |
Set IFS to the empty string when reading the filenames to avoid leading or trailing whitespace to be stripped from the name. It's not unlikely that other components of bee fail on filenames with trailing spaces, too, but that is not a reason to keep the bug in this tool.
donald
force-pushed
the
fix-funny-filenames
branch
from
3eea111
to
b091525
Compare
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow backslash and leading and trailing whitespace in image filenames.
Fixes #55