beesh: Abort if download fails #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May be wrong. |
Currently, bee doesn't detect the situation when a partial file is downloaded. An incomplete archive usually makes the following extract to fail, but the broken file is kept in the cache an needs to be removed manually. Only the the situation, when a failed download produced an empty file is explicitly handled. Currently, bee contains explicit code to ignore errors from wget. This code existed in the initial commit 067ccf2 ("initial revision") from 2010. The probably reason for it is, that the option `--no-globber` is used to avoid downloading a file, which already exists, a second time. However, wget terminates with a non-zero exit status in that case. Handle the case of an existing file in the calling code, so that we can treat any wget error as a real error and abort (by the `-e` setting of the shell). While we are at it, change code to download into a tempfile and rename it in the success case to avoid problems with partial downloads. This is more robust than the EXIT trap used by current code.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, bee doesn't detect the situation when a partial file is downloaded. An incomplete archive usually makes the following extract to fail, but the broken file is kept in the cache an needs to be removed manually. The situation, when a failed download produces an empty file, is already handled. Empty cache files are removed when bee is run the next time.
Currently, bee contains explicit code to ignore errors from wget. This code existed in the initial commit 067ccf2 ("initial revision") from
2010. The reasoning is unclear today and has to be rediscovered if it's still valid. So this patch is kind of experimental and might need to be undone.
Remove code to explicitly ignore wget failures. As the script is running with
-e, a wget failure should invoke the EXIT trap, which removes the incomplete file. This is untested.Fixes #57