mxqdump: List switch -a/--all for jobs-options in usage
#109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tend to prefer the |
With `mxqdump`, currently, reading the usage, it’s not clear how to dump
all jobs in a group without any filtering on the status, which defaults
to *running*. The code actually check if `arg_all` is set, meaning the
switch `-a`/`--all` is passed. So, document that in the usage.
Instead of `-a`/`--all` also `--status=all` or `--status=any` would be
possible, but also takes a different code path. As that is invisible to
the user, mention it as an alias.
Passing `--debug` shows the code paths taken:
$ mxqdump --debug --jobs -g 472581 -a
mxqdump mxqdump.c:737:main(): MySQL: Connection to database established.
mxqdump mxqdump.c:747:main(): DEBUG: DO: print all jobs in group_id=472581
[…]
$ mxqdump --debug --jobs -g 472581 --status=all # or any
mxqdump mxqdump.c:737:main(): MySQL: Connection to database established.
mxqdump mxqdump.c:754:main(): DEBUG: DO: print jobs in group_id=472581 with status='invalid(18446744073709551614)'
[…]
Fixes: #74
pmenzel
force-pushed
the
list-all-switch-in-mxqdump-job-options
branch
from
24260b3
to
b1a1282
Compare
|
Done. |
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.