mxq_job: Fix invalid pointer deref on error path #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got this from valgrind:
The pointer freed at the end of
mxq_select_job_from_group()
is supposedto be allocated by
mx_mysql_do_statement()
. However, the pointer isonly allocated in the common case, where the routine delivers a result:
In the unusual case that there was no result from the query (as above,
because other servers already started all pending jobs) or in error
cases,
job_id_out
might be uninitialized and thefree()
mightis invalid.
Make sure, we don't try to free via an unitialized pointer. Do not decide
based on the return value of
mx_mysql_do_statement()
, because we don'twant to duplicate the complicated logic in the if stated quited above to
be duplicated in the caller.