Skip to content
Jump to bottom

mxq_job: Fix invalid pointer deref on error path #84

Merged
merged 1 commit into from
Apr 15, 2020
Merged

mxq_job: Fix invalid pointer deref on error path #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions mxq_job.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ uint64_t mxq_select_job_from_group(struct mx_mysql *mysql, uint64_t group_id)
struct mx_mysql_bind param = {0};
struct mx_mysql_bind result = {0};
uint64_t job_id;
uint64_t *job_id_out;
uint64_t *job_id_out = NULL;
int res;

char *query =
Expand Down Expand Up @@ -321,7 +321,8 @@ uint64_t mxq_select_job_from_group(struct mx_mysql *mysql, uint64_t group_id)
} else {
job_id=0;
}
free(job_id_out);
if (job_id_out)
free(job_id_out);
return(job_id);
}

Expand Down