Skip to content

Commit

Permalink
net: dsa: remove tag_protocol from dsa_switch
Browse files Browse the repository at this point in the history
Having the tag protocol in dsa_switch_driver for setup time and in
dsa_switch_tree for runtime is enough. Remove dsa_switch's one.

Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Vivien Didelot authored and David S. Miller committed Apr 21, 2016
1 parent 2dabf0c commit c60c984
Showing 2 changed files with 2 additions and 8 deletions.
5 changes: 0 additions & 5 deletions include/net/dsa.h
Original file line number Diff line number Diff line change
@@ -135,11 +135,6 @@ struct dsa_switch {
*/
void *priv;

/*
* Tagging protocol understood by this switch
*/
enum dsa_tag_protocol tag_protocol;

/*
* Configuration data for this switch.
*/
5 changes: 2 additions & 3 deletions net/dsa/dsa.c
Original file line number Diff line number Diff line change
@@ -267,7 +267,7 @@ static int dsa_switch_setup_one(struct dsa_switch *ds, struct device *parent)
* switch.
*/
if (dst->cpu_switch == index) {
switch (ds->tag_protocol) {
switch (drv->tag_protocol) {
#ifdef CONFIG_NET_DSA_TAG_DSA
case DSA_TAG_PROTO_DSA:
dst->rcv = dsa_netdev_ops.rcv;
@@ -295,7 +295,7 @@ static int dsa_switch_setup_one(struct dsa_switch *ds, struct device *parent)
goto out;
}

dst->tag_protocol = ds->tag_protocol;
dst->tag_protocol = drv->tag_protocol;
}

/*
@@ -411,7 +411,6 @@ dsa_switch_setup(struct dsa_switch_tree *dst, int index,
ds->pd = pd;
ds->drv = drv;
ds->priv = priv;
ds->tag_protocol = drv->tag_protocol;
ds->master_dev = host_dev;

ret = dsa_switch_setup_one(ds, parent);

0 comments on commit c60c984

Please sign in to comment.